Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Storage PostObject #1248

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Update Storage PostObject #1248

merged 2 commits into from
Feb 20, 2017

Conversation

blowmage
Copy link
Contributor

Add some documentation, fix an issue when no policy is specified.

@blowmage
Update PostObject documentation
8ee1a41
@blowmage
Fix issue with PostObject
1da7d96 
If the user did not specify a policy, then no signature was returned.
@blowmage blowmage added docs api: storage Issues related to the Cloud Storage API. labels Feb 20, 2017
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 20, 2017
quartzmo
quartzmo approved these changes Feb 20, 2017
View reviewed changes
Copy link
Member

@quartzmo quartzmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added docs! LGTM.

@blowmage blowmage merged commit 8805dd1 into googleapis:master Feb 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quartzmo quartzmo quartzmo approved these changes

Assignees

@quartzmo quartzmo

Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blowmage @quartzmo @googlebot