Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle fluent-plugin-concat plugin into the package to deal with Docker log split issue. #260

Merged
merged 1 commit into from
May 26, 2020

Conversation

qingling128
Copy link

Docker 1.13 changed the way how it handle logs: entries longer than 16k bytes will be split to a number of entries with size <=16k. This causes a number of problems for our customers using Stackdriver like:

  • fragmented log lines
  • broken jsons

This aims at bundling that plugin into our package to make it easier for customer who is impacted to concatenate the logs.

…er log split issue.

Docker 1.13 changed the way how it handle logs: entries longer than 16k bytes will be split to a number of entries with size <=16k. This causes a number of problems for our customers using Stackdriver like:
- fragmented log lines
- broken jsons

This aims at bundling that plugin into our package to make it easier for customer who is impacted to concatenate the logs.
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@qingling128 qingling128 merged commit b9e1bc1 into master May 26, 2020
@qingling128 qingling128 deleted the lingshi-docker-concat branch May 26, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants