Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Windows agent startup type to 'Automatic (Delayed Start)'. #287

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Set Windows agent startup type to 'Automatic (Delayed Start)'. #287

merged 1 commit into from
Sep 14, 2020

Conversation

jkschulz
Copy link

@jkschulz jkschulz commented Sep 11, 2020 •
edited
Loading

Using flag introduced in fluent/fluentd#3037.

Built test agent/installer off of this branch and tested it in a Windows VM. Confirmed that the startup type is updated as expected:
image

@google-cla google-cla bot added the cla: yes label Sep 11, 2020
@jkschulz jkschulz requested a review from a team September 11, 2020 23:41
@ghost ghost requested review from igorpeshansky and removed request for a team September 11, 2020 23:41
igorpeshansky
igorpeshansky approved these changes Sep 13, 2020
View reviewed changes
Copy link
Member

@igorpeshansky igorpeshansky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@jkschulz jkschulz merged commit a1c9673 into master Sep 14, 2020
@jkschulz jkschulz deleted the jschulz-windows branch August 13, 2021 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorpeshansky igorpeshansky igorpeshansky approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkschulz @igorpeshansky