Allow fetching the latest grpc and protobuf source packages with core_gems #73
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider this as just one idea for how this could be done (I don't know much about the PR the testing in this repo and I've tested so far by checking the results of
bin/gem_downloader core_gems.rb
).This should fix protocolbuffers/protobuf#4210, by allowing
google-fluentd
to not need to pingrpc
andprotobuf
packages (grpc does not need a pin yet but it's tentative 1.9 release would start to need a pin).This is basically a workaround for the facts that:
The grpc/protobuf packaging process (done using
rake-compiler
), outputs an unnecessary and also unusable shared object when creating the pre-built shared objects packages (e.g.,grpc-1.8.7-x86_64-linux
)omnibus
checks the health of every shared object in the gem installation directory usingldd
.Longer term solution might be to patch
rake-compiler
to provide an option to not generate that fallback binary when we're creating a package with pre-built shared objects.