Add grpc version pin. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmoyles0117
reviewed
Feb 14, 2018
| @@ -11,3 +11,4 @@ | |||
| download "tzinfo", "1.2.2" | |||
| download "tzinfo-data", "1.2016.5" | |||
| download "google-protobuf", "3.5.1" | |||
| download "grpc", "1.9.1" | |||
There was a problem hiding this comment.
This wasn't here before, so I'm led to believe another one of the dependencies is pulling in a newer version. Will pinning this guarantee that this is what's being used as opposed to another version pulled in from another dependency?
There was a problem hiding this comment.
The reason this is new here is because that grpc switched to rake compiler in the latest release. Then this issue is triggered: rake-compiler/rake-compiler#146.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar with the
protobufissue, we need to pin grpc version as well.The long-term fix is rake-compiler/rake-compiler#146.