fix: Ignore state change for replaced subConns. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a replaced subConn shuts down, the balancer receives a READY->SHUTDOWN state change notification for that subConn. If we process this as usual, then we decrement ready channels count in the connectivityStateEvaluator. This will eventually lead to the aggregated state of the balancer being reported as TRANSIENT_FAILURE. This, in turn, infinitely blocks sending any RPC calls.
|
As discussed can we make sure that the code works in case of old connection shutting down before refresh connection comes up. |
|
Added the test. Will refactor the whole aggregated state evaluator stuff in a future PR. |
lasradoVinod
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a replaced subConn shuts down, the balancer receives a READY->SHUTDOWN state change notification for that subConn. If we process this as usual, then we decrement ready channels count in the connectivityStateEvaluator. This will eventually lead to the aggregated state of the balancer being reported as TRANSIENT_FAILURE. This, in turn, infinitely blocks sending any RPC calls.