Consolidate channel pool config in the GcpChannelPoolOptions. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Start moving channel pool related configuration into GcpChannelPoolOptions inside GcpManagedChannelOptions. Deprecate previous locations of pool config. Currently, we have several places to define max pool size, and we have a new pool related config options to come in the following PRs. We want to have a single place to define pool-related configuration. We will keep ApiConfig as a configuration for API methods only and move everything else into GcpManagedChannelOptions.
mohanli-ml
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start moving channel pool related configuration into GcpChannelPoolOptions
inside GcpManagedChannelOptions.
Deprecate previous locations of pool config.
Currently, we have several places to define max pool size, and we have a new
pool related config options to come in the following PRs.
We want to have a single place to define pool-related configuration. We will
keep ApiConfig as a configuration for API methods only and move everything else
into GcpManagedChannelOptions.
/cc @wenbozhu