Bind keys on the fly. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if GcpManagedChannel didn't get a key from a bind call, then it will always return the least busy channel for the key effectively providing no affinity. But it is not guaranteed that GcpManagedChannel will have a key from a bind call. E.g., an affinity key may be obtained by the upstream by other means. After this change a key will be mapped to a channel on a bind call or on the first use.
mohanli-ml
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if GcpManagedChannel didn't get a key from a bind call, then it will always return the least busy channel for the key effectively providing no affinity.
But it is not guaranteed that GcpManagedChannel will have a key from a bind call. E.g., an affinity key may be obtained by the upstream by other means.
After this change a key will be mapped to a channel on a bind call or on the first use.