MultiEndpoint metrics #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohanli-ml
approved these changes
Jan 26, 2023
| @@ -318,7 +518,15 @@ public synchronized void setMultiEndpoints(List<GcpMultiEndpointOptions> meOptio | |||
| defaultMultiEndpoint = multiEndpoints.get(meOptions.get(0).getName()); | |||
|
|
|||
| // Remove obsolete multiendpoints. | |||
| multiEndpoints.keySet().removeIf(name -> !currentMultiEndpoints.contains(name)); | |||
| Iterator<String> iter = multiEndpoints.keySet().iterator(); | |||
| while (iter.hasNext()) { | |||
There was a problem hiding this comment.
I am not familiar with Java, so this might be a stupid question. But since this is a loop, do you need to update iter? Like iter = iter.Next();
There was a problem hiding this comment.
no, there is no need in that. When we call iter.next() it advances the current item pointer and retrieves the item.
| } else if (fromIdx < toIdx) { | ||
| fallbackCnt++; | ||
| } else { | ||
| recoverCnt++; |
There was a problem hiding this comment.
Just double check, when fromIdx == toIdx, the type is also recover?
There was a problem hiding this comment.
fromIdx == toIdx if and only if toId.equals(fromId) because the priority assigned to an endpoint comes from incrementing counter and is unique. And this condition is checked in the first line of this method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new metrics for the multi-endpoint feature: