Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getPasswd: Check full prefix of line for username #81

Merged
merged 1 commit into from
Oct 1, 2020
Merged

getPasswd: Check full prefix of line for username #81

merged 1 commit into from
Oct 1, 2020

Conversation

Matir
Copy link
Contributor

@Matir Matir commented Sep 30, 2020

This fixes #80 where the username is checked with Contains, resulting in improper parsing when a username is a suffix of another username.

@Matir
getPasswd: Check full prefix of line for username
95880de 
This fixes GoogleCloudPlatform#80 where the username is checked with Contains, resulting in improper parsing when a username is a suffix of another username.
@google-cla google-cla bot added the cla: yes label Sep 30, 2020
@google-oss-robot
Copy link
Collaborator

Hi @Matir. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Matir
Copy link
Contributor Author

Matir commented Sep 30, 2020

/assign @adjackura

@hopkiw
Copy link
Contributor

hopkiw commented Sep 30, 2020

/approved

@hopkiw
Copy link
Contributor

hopkiw commented Sep 30, 2020

/approve

@google-oss-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hopkiw, Matir

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hopkiw hopkiw requested review from hopkiw and removed request for gaohannk September 30, 2020 21:43
@hopkiw
Copy link
Contributor

hopkiw commented Sep 30, 2020

/test all

@hopkiw
Copy link
Contributor

hopkiw commented Oct 1, 2020

/lgtm

@google-oss-robot google-oss-robot merged commit 369e63c into GoogleCloudPlatform:master Oct 1, 2020
patelne pushed a commit to patelne/guest-agent that referenced this pull request Feb 17, 2022
@gaohannk
Test manager container (GoogleCloudPlatform#81)
227c88b 
* container-build pipeline

* use build script

* address comments

* fix bug

* address comment

* address comment

* add e2e-test job and task

* address comment

* address comment

* move go get

* go mod tidy

* fix merge messy

* fix bug

* add group
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adjackura adjackura Awaiting requested review from adjackura

@hopkiw hopkiw Awaiting requested review from hopkiw

Assignees

@adjackura adjackura

@hopkiw hopkiw

Labels
approved cla: yes lgtm needs-ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improper parsing of /etc/passwd when username is suffix of another user
4 participants
@Matir @google-oss-robot @hopkiw @adjackura