Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nfs-server attached disk mounting. #1406

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Jun 2, 2023

  • Don't set google_compute_disk.image to avoid confused mounting;
  • Remove faulty and unnecessary yum -y install nfs-utils;
  • set -ex on install-nfs-server.sh;
  • format and mount attached disk explicitly.

@mr0re1 mr0re1 requested a review from cboneti June 2, 2023 21:33
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have left a few suggestions that I would like to see there.

@cboneti cboneti assigned mr0re1 and unassigned cboneti Jun 5, 2023
@mr0re1 mr0re1 assigned cboneti and unassigned mr0re1 Jun 6, 2023
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more queston

@cboneti cboneti assigned mr0re1 and unassigned cboneti Jun 6, 2023
@mr0re1 mr0re1 assigned cboneti and unassigned mr0re1 Jun 6, 2023
@mr0re1 mr0re1 enabled auto-merge June 7, 2023 20:01
@mr0re1 mr0re1 merged commit 3f513b5 into GoogleCloudPlatform:develop Jun 7, 2023
3 of 22 checks passed
@mr0re1 mr0re1 deleted the nfs branch June 28, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants