Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFE: new features and fixes. #2512

Merged
merged 28 commits into from
May 8, 2024

Conversation

ek-nag
Copy link
Collaborator

@ek-nag ek-nag commented Apr 23, 2024

This PR add the following features and fixes to the OFE:

  • Image import functionality, allows user to import existing image from the project to use when creating a cluster. It's handy when deploying multiple OFEs or migrating images from different projects.
  • Extending a list of nodes that allowed to have compact placement policy when creating partition.
  • Fixing broken static path for the /admin page.
  • Integrating private_vpc_connection is not unique per cluster in slurm-sql module #2054
  • Extending a list of required APIs in the deployment script.

scott-nag and others added 21 commits April 16, 2024 13:49
…i-fixes

OFE fix: Partition and node placement options
…-static-fix

OFE fix: static path for /admin
…ng-clusters-permissions

OFE fix: ps-connect, go location
Typo in _get_credentials_file function. Fixes GoogleCloudPlatform#37
…lop-image-import

Import existing images into OFE
Addition Secret Manager API to the required API list
Getting GO version from GO website
Typo in _get_credentials_file function. Fixes GoogleCloudPlatform#37
Addition Secret Manager API to the required API list
Copy link

google-cla bot commented Apr 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mr0re1
Copy link
Collaborator

mr0re1 commented Apr 23, 2024

/gcbrun

@nick-stroud nick-stroud self-assigned this Apr 24, 2024
@nick-stroud nick-stroud assigned ek-nag and unassigned nick-stroud Apr 24, 2024
@nick-stroud nick-stroud assigned nick-stroud and unassigned ek-nag May 3, 2024
@nick-stroud nick-stroud added the release-improvements Added to release notes under the "Improvements" heading. label May 7, 2024
@nick-stroud nick-stroud merged commit 185fa36 into GoogleCloudPlatform:develop May 8, 2024
10 of 49 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants