Make batch job runnables a list instead of single string #2516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronegolden
force-pushed
the
batch-multiple-runnables
branch
2 times, most recently
from
cd009ac
to
163097d
Compare
nick-stroud
reviewed
Apr 28, 2024
modules/scheduler/batch-job-template/templates/batch-job-base.yaml.tftpl
Show resolved
Hide resolved
modules/scheduler/batch-job-template/templates/batch-job-base.yaml.tftpl
Outdated
Show resolved
Hide resolved
aaronegolden
force-pushed
the
batch-multiple-runnables
branch
from
163097d
to
5d64db2
Compare
This way toolkit users can deploy batch jobs with multiple runnables. This can be convenient, for example, when the user wants to install something wih an initial "apt install" or "yum install" before running the "real" workload.
aaronegolden
force-pushed
the
batch-multiple-runnables
branch
from
5d64db2
to
5f39ac4
Compare
nick-stroud
added
the
release-module-improvements
|
/gcbrun |
nick-stroud
approved these changes
May 10, 2024
|
Approved, waiting for batch tests to run. |
nick-stroud
merged commit 3423904
into
GoogleCloudPlatform:develop
11 of 49 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way toolkit users can deploy batch jobs with multiple runnables. This can be convenient, for example, when the user wants to install something wih an initial "apt install" or "yum install" before running the "real" workload.
Submission Checklist
Please take the following actions before submitting this pull request.