Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll TGP to v5.28.0 #2535

Merged
merged 1 commit into from
May 10, 2024
Merged

Roll TGP to v5.28.0 #2535

merged 1 commit into from
May 10, 2024

Conversation

alyssa-sm
Copy link
Contributor

@alyssa-sm alyssa-sm commented Apr 30, 2024 •
edited
Loading

This PR rolls TGP from v4.84 to v5.28 by updating references to versions and sets the default for deletion_protection since that is new in 5.0.

@alyssa-sm alyssa-sm self-assigned this Apr 30, 2024
@alyssa-sm alyssa-sm force-pushed the roll-TGP-to-v5 branch 9 times, most recently from 8457510 to c88b359 Compare May 7, 2024 20:00
@alyssa-sm alyssa-sm changed the title Roll TGP to v5.26.0 Roll TGP to v5.28.0 May 7, 2024
@alyssa-sm alyssa-sm added the do-not-merge Block merging of this PR label May 7, 2024
@alyssa-sm alyssa-sm marked this pull request as ready for review May 7, 2024 20:13
@tpdownes tpdownes mentioned this pull request May 9, 2024
Merged
@alyssa-sm alyssa-sm force-pushed the roll-TGP-to-v5 branch 3 times, most recently from 0f3e19f to 027efc4 Compare May 9, 2024 23:19
tpdownes
tpdownes requested changes May 10, 2024
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change on the A3/machine-learning blueprint is necessary but should not require re-running tests.

examples/machine-learning/ml-slurm-a3-1-image.yaml Outdated Show resolved Hide resolved
pkg/modulewriter/tfwriter.go Show resolved Hide resolved
@alyssa-sm alyssa-sm requested a review from tpdownes May 10, 2024 19:12
@alyssa-sm alyssa-sm assigned tpdownes and unassigned alyssa-sm May 10, 2024
@tpdownes tpdownes added release-key-new-features Added to release notes under the "Key New Features" heading. and removed do-not-merge Block merging of this PR labels May 10, 2024
@tpdownes tpdownes enabled auto-merge May 10, 2024 19:41
@tpdownes tpdownes merged commit 1d7691c into GoogleCloudPlatform:develop May 10, 2024
10 of 51 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@tpdownes tpdownes

Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssa-sm @tpdownes