Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove login infix from instance name #2540

Merged
merged 1 commit into from
May 7, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented May 1, 2024

  • Avoid instance names like xxx-slurm-login-login-yyy;
  • Makes blueprints more compact by removing need to always specify var. name_prefix.

@mr0re1 mr0re1 added the release-chore To not include into release notes label May 1, 2024
@mr0re1 mr0re1 self-assigned this May 2, 2024
@mr0re1 mr0re1 requested a review from nick-stroud May 3, 2024 17:53
@mr0re1 mr0re1 assigned nick-stroud and unassigned mr0re1 May 3, 2024
@mr0re1 mr0re1 changed the title Revert "Revert #2351" Remove login infix from instance name May 3, 2024
@nick-stroud nick-stroud assigned mr0re1 and unassigned nick-stroud May 7, 2024
@mr0re1 mr0re1 added release-module-improvements Added to release notes under the "Module Improvements" heading. and removed release-chore To not include into release notes labels May 7, 2024
@mr0re1 mr0re1 merged commit af61507 into GoogleCloudPlatform:develop May 7, 2024
29 of 52 checks passed
@mr0re1 mr0re1 deleted the login_again branch May 7, 2024 17:15
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants