Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFE: fixing broken partitions update logic. #2563

Merged
merged 7 commits into from
May 10, 2024

Conversation

ek-nag
Copy link
Collaborator

@ek-nag ek-nag commented May 8, 2024

Fixing the following OFE bug with this PR:

Bug report: I can consistently reproduce the following behavior:

I create a cluster with 3 partitions: a, b, c (I have been using default settings)
wait for cluster to fully deploy
edit cluster
delete middle partition ("b")
click update

Expected behavior: partition "b" is deleted, partition "a" and "c" remain
Actual behavior: generated blueprint has both "b" and "c" partitions deleted, when changes are applied to cluster only partition "a" remains.

Moving from hardcoded blueprint yaml code in the Django Python to jinja template files for better flexibility, easier development.

@nick-stroud nick-stroud self-assigned this May 9, 2024
@nick-stroud nick-stroud added release-improvements Added to release notes under the "Improvements" heading. release-bugfix Added to release notes under the "Bug fixes" heading. and removed release-improvements Added to release notes under the "Improvements" heading. labels May 10, 2024
@nick-stroud nick-stroud merged commit 5f61071 into GoogleCloudPlatform:develop May 10, 2024
12 of 52 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants