Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specific reservation for node-group in slurm-gcp v5 #2614

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented May 21, 2024

Manual testing with 3 node-groups

For all specific reservation: --> No errors.

For 1 automatic reservation:

│   79:       condition     = coalesce(self.specific_reservation_required, true)
│     ├────────────────
│     │ self.specific_reservation_required is false
│
│ your reservation has to be specific,
│       see https://cloud.google.com/compute/docs/instances/reservations-overview#how-reservations-work
│       for more information. if it's intentionally automatic, don't specify
│       it in the blueprint.

For 2 automatic reservation:

Plan: 33 to add, 0 to change, 0 to destroy.
╷
│ Error: Resource postcondition failed
│
│   on modules/embedded/community/modules/compute/schedmd-slurm-gcp-v5-partition/main.tf line 79, in data "google_compute_reservation" "reservation":
│   79:       condition     = coalesce(self.specific_reservation_required, true)
│     ├────────────────
│     │ self.specific_reservation_required is false
│
│ your reservation has to be specific,
│       see https://cloud.google.com/compute/docs/instances/reservations-overview#how-reservations-work
│       for more information. if it's intentionally automatic, don't specify
│       it in the blueprint.
╵
╷
│ Error: Resource postcondition failed
│
│   on modules/embedded/community/modules/compute/schedmd-slurm-gcp-v5-partition/main.tf line 79, in data "google_compute_reservation" "reservation":
│   79:       condition     = coalesce(self.specific_reservation_required, true)
│     ├────────────────
│     │ self.specific_reservation_required is false
│
│ your reservation has to be specific,
│       see https://cloud.google.com/compute/docs/instances/reservations-overview#how-reservations-work
│       for more information. if it's intentionally automatic, don't specify
│       it in the blueprint.

For 1 automatic and 1 not found.

Plan: 33 to add, 0 to change, 0 to destroy.
╷
│ Error: Resource postcondition failed
│
│   on modules/embedded/community/modules/compute/schedmd-slurm-gcp-v5-partition/main.tf line 74, in data "google_compute_reservation" "reservation":
│   74:       condition     = self.self_link != null
│     ├────────────────
│     │ self.self_link is null
│
│ couldn't find the reservation helloautomaticreservation123}
╵
╷
│ Error: Resource postcondition failed
│
│   on modules/embedded/community/modules/compute/schedmd-slurm-gcp-v5-partition/main.tf line 79, in data "google_compute_reservation" "reservation":
│   79:       condition     = coalesce(self.specific_reservation_required, true)
│     ├────────────────
│     │ self.specific_reservation_required is false
│
│ your reservation has to be specific,
│       see https://cloud.google.com/compute/docs/instances/reservations-overview#how-reservations-work
│       for more information. if it's intentionally automatic, don't specify
│       it in the blueprint.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-bugfix Added to release notes under the "Bug fixes" heading. label May 21, 2024
@harshthakkar01 harshthakkar01 changed the base branch from develop to release-candidate May 21, 2024 23:25
@harshthakkar01 harshthakkar01 merged commit 8052071 into GoogleCloudPlatform:release-candidate May 21, 2024
6 of 46 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants