Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spack setup runner #586

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Add Spack setup runner #586

merged 1 commit into from
Sep 30, 2022
+51 −10

Conversation

nick-stroud
Copy link
Collaborator

Spawned from #539.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

tpdownes
tpdownes approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested an observed to work on AMD blueprint's login node. Thank you for
updating the blueprint to use it.

@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Sep 30, 2022
@nick-stroud nick-stroud merged commit ce35fb8 into GoogleCloudPlatform:develop Sep 30, 2022
@nick-stroud nick-stroud mentioned this pull request Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@nick-stroud nick-stroud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nick-stroud @tpdownes