Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: Improve "Float" window mode #712

Closed
rmatte opened this issue Jul 8, 2022 · 3 comments
Closed

Enhancement request: Improve "Float" window mode #712

rmatte opened this issue Jul 8, 2022 · 3 comments
Labels
enhancement New feature or request next-release Scheduled for upcoming release

Comments

@rmatte
Copy link

rmatte commented Jul 8, 2022

When setting an ssh or rdp tab to the "Float" mode it would be nice if it would become it's own window (selectable on the taskbar) with maximize/minimize controls. Currently it doesn't and as soon as you go to maximize it by double clicking on the title bar it snaps right back in to the main window. It's awkward to work with.

I'd recommend switching out the "float" mode option to an "unsnap tab" type feature and having each unsnapped tab as it's own window with it's own controls.

I'm loving this app and I'm sure this is something that a lot of google cloud users want (to be able to have their ssh and rdp sessions through iap via an actual desktop app) but this is a pretty severe usability pain point with it at the moment.

As an aside, it would be great if this project were given more development resources. I didn't even realize this existed until today, this would be something excellent to advertise in the google cloud web console as being an access option once the software is a bit more mature and the installation on macos and linux is simplified.

@rmatte rmatte changed the title "Float" window mode enhancement request Enhancement request: Improve "Float" window mode Jul 8, 2022
@jpassing
Copy link
Collaborator

Thanks for your feedback and this feature suggestion!

I'd recommend switching out the "float" mode option to an "unsnap tab" type feature and having each unsnapped tab as it's own window with it's own controls.

If I understand your idea correctly, then the separate window would...

  • have the usual minimize/maximize/close window controls
  • show up in the task bar
  • host one or more tabs/sessions
  • not have a menu (unlike the main window)
  • close automatically if you close the main window

That's pretty much how modern Visual Studio versions behave when you "tear off" a document, so I think that would make sense. I'll have to check whether the underlying library supports this kind of windowing behavior.

@jpassing jpassing added the enhancement New feature or request label Jul 11, 2022
@rmatte
Copy link
Author

rmatte commented Jul 11, 2022

That's exactly right, and if the new window only has one tab in it don't display the tab at the top, just the terminal or rdp session by itself in the window. Or at least have an option to hide the tab in it.

@jpassing jpassing added the next-release Scheduled for upcoming release label Sep 6, 2022
jpassing added a commit that referenced this issue Sep 7, 2022
* Set float window properties after creation
* Use custom float window factory to fix faulty
  handling of the Minimize button in DockPanelSuite
* Consider float windows when setting context
  for session menu/commands

Cf #712
@jpassing
Copy link
Collaborator

jpassing commented Oct 7, 2022

This feature is now available in release 2.32. Thanks again for the suggestion.

@jpassing jpassing closed this as completed Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request next-release Scheduled for upcoming release
Projects
None yet
Development

No branches or pull requests

2 participants