Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Adds functions_helloworld_background #1549

Merged
merged 2 commits into from Aug 15, 2019
Merged

Feat: Adds functions_helloworld_background #1549

merged 2 commits into from Aug 15, 2019

Conversation

grant
Copy link
Contributor

@grant grant commented Aug 15, 2019 •
edited

Adds bg functions snippet
https://devrel.corp.google.com/samples/82

@grant grant requested review from ace-n and a team August 15, 2019 20:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 15, 2019
@ace-n
Copy link
Contributor

ace-n commented Aug 15, 2019

N.B: this may be blocked on #1506 due to dependency issues (e.g. gson).

ace-n
ace-n reviewed Aug 15, 2019
View reviewed changes
Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm not a Java expert.

@grant grant requested a review from kurtisvg August 15, 2019 21:54
@kurtisvg kurtisvg assigned kurtisvg and unassigned dzlier-gcp Aug 15, 2019
@grant grant merged commit c2bc743 into master Aug 15, 2019
@grant grant deleted the grant_functions_helloworld_background branch August 15, 2019 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n left review comments

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grant @ace-n @kurtisvg @googlebot @dzlier-gcp