Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default to PickFirstLoadBalancerProvider #2063

Merged

Conversation

olavloite
Copy link
Contributor

The services/META-INF/io.grpc.LoadBalancerProvider file included by default in the jar with dependencies did not correspond with the default pick_first policy of AutoConfiguredLoadBalancerFactory.

Fixes #2061

The services/META-INF/io.grpc.LoadBalancerProvider file included by
default in the jar with dependencies did not correspond with the
default pick_first policy of AutoConfiguredLoadBalancerFactory.

Fixes GoogleCloudPlatform#2061
@olavloite olavloite requested a review from a team February 11, 2020 12:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2020
Copy link
Contributor

@skuruppu skuruppu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. I assume that commands in the getting started guide will still work. I didn't try the change myself.

java -jar target/spanner-google-cloud-samples-jar-with-dependencies.jar \
    createdatabase test-instance example-db

@olavloite
Copy link
Contributor Author

@skuruppu Yes, I tried with the exact steps up until and including the command mentioned above (and in the Getting Started documentation).

@lesv lesv merged commit c2188a9 into GoogleCloudPlatform:master Feb 15, 2020
@olavloite olavloite deleted the spanner-fix-pick-first-loadbalancer branch February 15, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spanner: "Could not find policy 'pick_first'" when running "Getting started with Cloud Spanner in Java" guide
5 participants