Final additions in private beta #861

gguuss · 2017-09-23T00:51:27Z

Placeholder

jabubake

LGTM, minor comments

jabubake · 2017-09-26T17:50:56Z

iot/api-client/http_example/README.md

+1. Create a subscription to your topic.
+
+```
+    gcloud beta pubsub subscriptions create \


I assume gcloud installation is covered in the parent README ?

Yes, the guide, linked in the doc, covers this.

jabubake · 2017-09-26T17:51:11Z

iot/api-client/http_example/pom.xml

@@ -0,0 +1,47 @@
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"


missing license header

Added here and elsewhere.

jabubake · 2017-09-26T18:04:36Z

iot/api-client/http_example/src/main/java/com/google/cloud/iot/examples/HttpExample.java

+      System.out.println(httpCon.getResponseMessage());
+
+      // Send events every second; states, every 5.
+      Thread.sleep(options.messageType.equals("event") ? 1000 : 5000);


it might be worth pulling out that param to sleep in a separate statement. so that the sleep statement is clearer.

jabubake · 2017-09-26T18:05:41Z

iot/api-client/manager/pom.xml

    <dependency>
      <groupId>com.google.apis</groupId>
      <artifactId>google-api-services-cloudiot</artifactId>
      <version>v1beta1-rev20170418-1.22.0-SNAPSHOT</version>
    </dependency>
+    -->
    <dependency>
      <groupId>com.google.cloud</groupId>
      <artifactId>google-cloud-pubsub</artifactId>


update to latest google-cloud-java libs

jabubake · 2017-09-26T18:07:18Z

iot/api-client/manager/pom.xml

+      <artifactId>guava</artifactId>
+      <version>23.0</version>
+    </dependency>
+    <dependency>
      <groupId>com.google.api-client</groupId>


can you confirm this is needed ? given you do include a google-cloud-java library:
https://github.com/GoogleCloudPlatform/google-cloud-java/blob/master/pom.xml#L750

The tests will not work without explicitly including this.

@gguuss : I meant google-api-client and not guava. But if that too is the case, that tests don't compile, i'll take a look post-merge.

Updated, tests work still :)

jabubake · 2017-09-26T18:14:20Z

iot/api-client/mqtt_example/src/main/java/com/google/cloud/iot/examples/MqttExample.java

-      Thread.sleep(1000);
+
+      // Send events every second. State should not be updated as often
+      Thread.sleep(options.messageType.equals("event") ? 1000 : 5000);


same as earlier, the comment seems to be a little distracting. "Send events every second... " above a Thread.sleep method

jabubake · 2017-09-26T18:15:17Z

iot/api-client/mqtt_example/src/main/java/com/google/cloud/iot/examples/MqttExample.java

-      Thread.sleep(1000);
+
+      // Send events every second. State should not be updated as often
+      Thread.sleep(options.messageType.equals("event") ? 1000 : 5000);
    }
    // Disconnect the client and finish the run.
    client.disconnect();


is this automatically done if there is an exception ? Is it worth moving this to a finally block ?

…/java-docs-samples into iot-snippets

gguuss · 2017-09-26T19:42:08Z

Addressed review feedback and added a few missing license headers.

jabubake

Merge blocked till client libraries are updated to latest version.

…/java-docs-samples into iot-snippets

gguuss · 2017-09-26T20:37:46Z

@jabubake Updated with an appropriate snapshot version, I'm not seeing the client library on Apiary yet, customers will continue to need to install from jar.

rafaelsf80 · 2017-10-08T20:43:58Z

Hi,

Tried to compile the mqtt java client on a raspberry pi3, and got an error at $mvn clean compile

[FATAL] Non-resolvable parent POM for com.google.cloud.iot.examples:cloudiot-mqtt-example:1.0: Could not find artifact com.google.cloud:doc-samples:pom:1.0.0 in Eclipse Paho Repo (https://repo.eclipse.org/content/repositories/paho-releases/org/eclipse/paho) and 'parent.relativePath' points at wrong local POM @ line 32, column 11

Removing the parent section on the pom.xml and updating the repository from https://repo.eclipse.org/content/repositories/paho-releases/ to https://repo.eclipse.org/content/repositories/paho-releases/org/eclipse/paho/ on the pom.xml solved the issue.
Not sure if pom.xml should be modified accordingly.

Regards,
Rafa

…-ai to v2.6.0 (#861) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-document-ai](https://togithub.com/googleapis/java-document-ai) | `2.5.2` -> `2.6.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.6.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.6.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.6.0/compatibility-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-document-ai/2.6.0/confidence-slim/2.5.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).

…861) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.3.0` -> `2.3.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.3.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.3.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.3.1/compatibility-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.3.1/confidence-slim/2.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.3.1`](https://togithub.com/googleapis/java-core/blob/master/CHANGELOG.md#231-httpswwwgithubcomgoogleapisjava-corecomparev230v231-2021-11-15) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.3.0...v2.3.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).

Final additions in private beta

15f5197

gguuss added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 23, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 23, 2017

gguuss added 4 commits September 22, 2017 17:51

Merge branch 'master' into iot-snippets

2f55341

Final updates in private beta

2fdad02

Adds tests, state support, and HTTP client

2f5aafc

Merge branch 'master' into iot-snippets

7b23b34

jabubake reviewed Sep 26, 2017

View reviewed changes

jabubake and others added 3 commits September 26, 2017 11:16

Merge branch 'master' into iot-snippets

376faff

Feedback from review

b2845e3

Merge branch 'iot-snippets' of https://github.com/googlecloudplatform…

e22a01c

…/java-docs-samples into iot-snippets

jabubake approved these changes Sep 26, 2017

View reviewed changes

gguuss removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 26, 2017

gguuss added 3 commits September 26, 2017 13:18

Merge branch 'master' into iot-snippets

bd8c80b

Updates to snapshot version of sample library dependency

8a0a005

Merge branch 'iot-snippets' of https://github.com/googlecloudplatform…

99cc747

…/java-docs-samples into iot-snippets

jabubake merged commit a1a3ded into master Sep 26, 2017

jabubake deleted the iot-snippets branch September 26, 2017 20:47

Shabirmean mentioned this pull request Nov 15, 2022

samples: migrate code from googleapis/java-document-ai #7427

Merged

9 tasks

Shabirmean mentioned this pull request Nov 17, 2022

samples: migrate code from googleapis/java-translate #7443

Closed

9 tasks

Shabirmean mentioned this pull request Nov 18, 2022

samples: migrate code from googleapis/java-translate #7445

Merged

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Final additions in private beta #861

Final additions in private beta #861

gguuss commented Sep 23, 2017

jabubake left a comment

jabubake Sep 26, 2017

gguuss Sep 26, 2017

jabubake Sep 26, 2017

gguuss Sep 26, 2017

jabubake Sep 26, 2017

jabubake Sep 26, 2017

gguuss Sep 26, 2017

jabubake Sep 26, 2017

gguuss Sep 26, 2017

jabubake Sep 26, 2017

gguuss Sep 26, 2017

jabubake Sep 26, 2017

jabubake Sep 26, 2017

gguuss commented Sep 26, 2017

jabubake left a comment

gguuss commented Sep 26, 2017

rafaelsf80 commented Oct 8, 2017 •

edited

Loading

		@@ -0,0 +1,47 @@
		<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

Final additions in private beta #861

Final additions in private beta #861

Conversation

gguuss commented Sep 23, 2017

jabubake left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gguuss commented Sep 26, 2017

jabubake left a comment

Choose a reason for hiding this comment

gguuss commented Sep 26, 2017

rafaelsf80 commented Oct 8, 2017 • edited Loading

rafaelsf80 commented Oct 8, 2017 •

edited

Loading