Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Text-embedding model tuning demo. #9272

Conversation

lee1premium
Copy link
Contributor

Description

Fixes: http://b/320696823

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@lee1premium lee1premium requested review from yoshi-approver and a team as code owners March 27, 2024 04:06
Copy link

snippet-bot bot commented Mar 27, 2024

Here is the summary of changes.

You are about to add 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels Mar 27, 2024
@lee1premium
Copy link
Contributor Author

@minherz Can we move on rather than addressing your concerns, after we create bugs for code quality problems? I cannot make a big difference over Vertex AI platform code samples.

I appreciate your comments/code quality concerns. I didn't come up with such bad coding practice. I just repeated the same, bad pratice from https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/aiplatform/src

  • You can find a ton of samples using the same region tags.
  • You can find a few other samples using the same catch clauses.
  • You can find a few other samples using the same retry over deletion.
  • You can find a ton of samples using STDOUT for testing.

@minherz
Copy link
Contributor

minherz commented Mar 27, 2024

@minherz Can we move on rather than addressing your concerns, after we create bugs for code quality problems? I cannot make a big difference over Vertex AI platform code samples.

The whole point of the code review is code quality. We don't need the review if we can skip this phase. I find the code hard for maintenance due to lack of resilience in test implementation and running times.
I pointed to a violation of guidelines and a redundant code lines that are easily fixable and improve the code quality.
Please remember, that this code represents Google engineering quality among other things. I do believe the investing some time worth the effort.

@lee1premium
Copy link
Contributor Author

@minherz Done rewriting the sample and test. Please, take a look.

Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your work. Consider addressing the minor comments.

@gericdong gericdong added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2024
@davidcavazos
Copy link
Contributor

err: signal: killed after 27 minutes, looks like a timeout. Something's taking too long during the test.

@lee1premium
Copy link
Contributor Author

How can you ignore these irrelevant, flaky tests? I have no way to see the pipeline creation failure details at projects/ucaip-sample-tests.

Java 11 - CI failed at aiplatform.CreateTrainingPipelineSampleTest and aiplatform.CancelTrainingPipelineSampleTest

  • Caused by: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: The TrainingPipeline "projects/ucaip-sample-tests/locations/us-central1/trainingPipelines/6971726189157154816" is in state PIPELINE_STATE_FAILED and cannot be canceled.
  • Caused by: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: The TrainingPipeline "projects/ucaip-sample-tests/locations/us-central1/trainingPipelines/4361890205095952384" is in state PIPELINE_STATE_FAILED and cannot be canceled.

Java 17 - CI failed at aiplatform.CancelTrainingPipelineSampleTest

  • Caused by: io.grpc.StatusRuntimeException: FAILED_PRECONDITION: The TrainingPipeline "projects/ucaip-sample-tests/locations/us-central1/trainingPipelines/4551745076887289856" is in state PIPELINE_STATE_FAILED and cannot be canceled.

@kweinmeister kweinmeister merged commit 61c9d9e into GoogleCloudPlatform:main Apr 8, 2024
8 checks passed
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 7, 2024
* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.
@lee1premium lee1premium deleted the tuned-text-embedding--2024-03 branch May 21, 2024 01:34
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-embedding model tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.

* feat: Text-Embedding Model Tuning demo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants