-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Text-embedding model tuning demo. #9272
feat: Text-embedding model tuning demo. #9272
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
aiplatform/src/main/java/aiplatform/CreatePipelineJobEmbeddingModelTuningSample.java
Outdated
Show resolved
Hide resolved
aiplatform/src/test/java/aiplatform/CreatePipelineJobEmbeddingModelTuningSampleTest.java
Outdated
Show resolved
Hide resolved
aiplatform/src/test/java/aiplatform/CreatePipelineJobEmbeddingModelTuningSampleTest.java
Outdated
Show resolved
Hide resolved
aiplatform/src/test/java/aiplatform/CreatePipelineJobEmbeddingModelTuningSampleTest.java
Outdated
Show resolved
Hide resolved
@minherz Can we move on rather than addressing your concerns, after we create bugs for code quality problems? I cannot make a big difference over Vertex AI platform code samples. I appreciate your comments/code quality concerns. I didn't come up with such bad coding practice. I just repeated the same, bad pratice from https://github.com/GoogleCloudPlatform/java-docs-samples/tree/main/aiplatform/src
|
The whole point of the code review is code quality. We don't need the review if we can skip this phase. I find the code hard for maintenance due to lack of resilience in test implementation and running times. |
@minherz Done rewriting the sample and test. Please, take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work. Consider addressing the minor comments.
aiplatform/src/main/java/aiplatform/EmbeddingModelTuningSample.java
Outdated
Show resolved
Hide resolved
aiplatform/src/main/java/aiplatform/EmbeddingModelTuningSample.java
Outdated
Show resolved
Hide resolved
|
How can you ignore these irrelevant, flaky tests? I have no way to see the pipeline creation failure details at Java 11 - CI failed at aiplatform.CreateTrainingPipelineSampleTest and aiplatform.CancelTrainingPipelineSampleTest
Java 17 - CI failed at aiplatform.CancelTrainingPipelineSampleTest
|
aiplatform/src/main/java/aiplatform/EmbeddingModelTuningSample.java
Outdated
Show resolved
Hide resolved
* feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo.
* feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-embedding model tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo. * feat: Text-Embedding Model Tuning demo.
Description
Fixes: http://b/320696823
Checklist
pom.xml
parent set to latestshared-configuration
mvn clean verify
requiredmvn -P lint checkstyle:check
requiredmvn -P lint clean compile pmd:cpd-check spotbugs:check
advisory only