feat: Adding disable role snippet #9295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
samples
msilc
changed the title
kweinmeister
added
the
kokoro:run
kokoro-team
removed
the
kokoro:run
Sita04
requested changes
Apr 23, 2024
| UpdateRoleRequest updateRoleRequest = | ||
| UpdateRoleRequest.newBuilder() | ||
| .setName(roleName) | ||
| .setRole(roleBuilder) |
There was a problem hiding this comment.
Instead of the Role.Builder, can we use Role?
Comment on lines
39
to
42
| Role.Builder roleBuilder = | ||
| Role.newBuilder() | ||
| .setName(roleName) | ||
| .setStage(Role.RoleLaunchStage.DISABLED); |
There was a problem hiding this comment.
Can we build this and get back the Role, like below?
Suggested change
| Role.Builder roleBuilder = | |
| Role.newBuilder() | |
| .setName(roleName) | |
| .setStage(Role.RoleLaunchStage.DISABLED); | |
| Role role = | |
| Role.newBuilder() | |
| .setName(roleName) | |
| .setStage(Role.RoleLaunchStage.DISABLED) | |
| .build(); |
| // once, and can be reused for multiple requests. | ||
| try (IAMClient iamClient = IAMClient.create()) { | ||
| Role result = iamClient.updateRole(updateRoleRequest); | ||
| System.out.println("Disabled role:\n" + result); |
There was a problem hiding this comment.
Kindly return the updated role to be used in test assert statements.
| @@ -111,6 +111,10 @@ public void testRole() throws IOException { | |||
| ListRoles.listRoles(projectId); | |||
| assertThat(bout.toString().contains(roleId)); | |||
|
|
|||
| // Test disable role. | |||
| DisableRole.disableRole(projectId, roleId); | |||
| assertThat(bout.toString().contains("Stage: DISABLED")); | |||
There was a problem hiding this comment.
Instead of asserting from sysout, it's more robust to retrieve and verify the status from the updated role.
Sita04
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sita04
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@msilc PTAL at the lint issues |
kokoro-team
removed
the
kokoro:run
rafaelMurata
pushed a commit
to rafaelMurata/java-docs-samples
that referenced
this pull request
May 7, 2024
* Added the disable role snippet * Refactoring * Updated header * PR fix * Checkstyle fix * Names reverted
rafaelMurata
pushed a commit
to rafaelMurata/java-docs-samples
that referenced
this pull request
May 27, 2024
* Added the disable role snippet * Refactoring * Updated header * PR fix * Checkstyle fix * Names reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a new disable role snippet
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only