Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset inventory: searchAllResources sample not working for Bigquery Dataset #8798 #9297

Merged
merged 1 commit into from
May 1, 2024

Conversation

ssvir
Copy link
Contributor

@ssvir ssvir commented Apr 22, 2024

Description

Unignore SearchIT.testSearchAllResourcesExample cause problems with the dataset are fixed, and the test working

Fixes #8798

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ssvir ssvir requested review from yoshi-approver and a team as code owners April 22, 2024 10:18
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: cloudasset Issues related to the Cloud Asset Inventory API. labels Apr 22, 2024
@kweinmeister kweinmeister added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 22, 2024
@Sita04
Copy link
Contributor

Sita04 commented Apr 23, 2024

@ssvir Could you please link the PR which fixed the issue with the dataset?

@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2024
@Sita04 Sita04 assigned Sita04 and unassigned angieshen-google Apr 23, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 23, 2024
@ssvir
Copy link
Contributor Author

ssvir commented Apr 23, 2024

@ssvir Could you please link the PR which fixed the issue with the dataset?

Hey @Sita04 , I tried to find those changes, but it looks like we have no changes inside this test or inside SearchAllResourcesExample.searchAllResources, and I checked all issues inside #8798 and didn't find anything useful, either. I guess the main changes present inside BigQuery lib.

@Sita04 Sita04 merged commit 9b7afff into main May 1, 2024
11 checks passed
@Sita04 Sita04 deleted the fix-issue-8798 branch May 1, 2024 18:22
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 7, 2024
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset inventory: searchAllResources sample not working for Bigquery Dataset
5 participants