Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gemini code sample and test for text-only input #9310

Merged
merged 3 commits into from
May 7, 2024
Merged

feat: add gemini code sample and test for text-only input #9310

merged 3 commits into from
May 7, 2024

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented May 7, 2024

Description

Fixes b:336785030

  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from yoshi-approver and a team as code owners May 7, 2024 17:50
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented May 7, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 7, 2024
Sita04
Sita04 approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.
Will wait for Eric's approval to merge.

vertexai/snippets/src/main/java/vertexai/gemini/TextInput.java Show resolved Hide resolved
vertexai/snippets/src/main/java/vertexai/gemini/TextInput.java Outdated Show resolved Hide resolved
@irataxy irataxy requested a review from gericdong May 7, 2024 20:21
@gericdong gericdong merged commit 79b4a90 into GoogleCloudPlatform:main May 7, 2024
8 checks passed
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@irataxy @rafaelMurata
feat: add gemini code sample and test for text-only input (GoogleClou…
0c3971d 
…dPlatform#9310)

* feat: add gemini code sample and test for text-only input

* address feedback

* fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@gericdong gericdong gericdong approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@bourgeoisor bourgeoisor

@gericdong gericdong

Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@irataxy @Sita04 @gericdong @bourgeoisor