Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Text Embedding Sample override 003 model to 004 #9313

Merged
merged 1 commit into from
May 8, 2024
Merged

feat: Text Embedding Sample override 003 model to 004 #9313

merged 1 commit into from
May 8, 2024

Conversation

kewent
Copy link
Contributor

@kewent kewent commented May 8, 2024

Description

Fixes: http://b/334964454

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@kewent kewent requested review from yoshi-approver and a team as code owners May 8, 2024 06:37
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: aiplatform Issues related to the AI Platform API. labels May 8, 2024
minherz
minherz approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aiplatform/src/main/java/aiplatform/PredictTextEmbeddingsSample.java
Comment on lines -53 to +59
String endpoint, String project, String model, List<String> texts, String task)
String endpoint,
String project,
String model,
List<String> texts,
String task,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: was it possible to keep formatting of these arguments unchanged in order to minimize differences and reduce load on reviewing changes?

@minherz minherz merged commit bf2cb62 into GoogleCloudPlatform:main May 8, 2024
8 checks passed
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@kewent @rafaelMurata
feat: override 003 model to 004 (GoogleCloudPlatform#9313)
c60b9a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minherz minherz minherz approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@minherz minherz

Labels
api: aiplatform Issues related to the AI Platform API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kewent @minherz