Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compute/cloud-client test(s) are failing #8965 #9329

Merged
merged 1 commit into from
May 15, 2024
Merged

compute/cloud-client test(s) are failing #8965 #9329

merged 1 commit into from
May 15, 2024

Conversation

ssvir
Copy link
Collaborator

@ssvir ssvir commented May 13, 2024

Description

unignore tests, rerun 5 times without failings
Fixes #8965

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ssvir ssvir requested a review from Sita04 May 13, 2024 09:54
@ssvir ssvir requested review from yoshi-approver and a team as code owners May 13, 2024 09:54
@product-auto-label product-auto-label bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. labels May 13, 2024
@ssvir ssvir added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 13, 2024
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2024
@ssvir ssvir merged commit 7239b64 into main May 15, 2024
11 checks passed
@ssvir ssvir deleted the fix-issue-8965 branch May 15, 2024 15:20
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
@ssvir @rafaelMurata
unignore tests, rerun 5 times without failings (GoogleCloudPlatform#9329
711ee97 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels
api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compute/cloud-client test(s) are failing
3 participants
@ssvir @Sita04 @kokoro-team