feat(vertexai): support system instruction #9330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function calling example
Fix typo in project ID string
… google-cloud-vertexai SDK Use the same example for the token count as in Python and Golang
# Conflicts: # vertexai/snippets/src/main/java/vertexai/gemini/FunctionCalling.java # vertexai/snippets/src/test/java/vertexai/gemini/SnippetsIT.java
…eedback, fixing region tags, and clarifying comments)
product-auto-label
bot
added
the
samples
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
gericdong
approved these changes
May 13, 2024
Sita04
reviewed
May 13, 2024
| System.out.println(output); | ||
| } | ||
|
|
||
| // Ask the model to translate from English to French thanks to a system instruction. |
There was a problem hiding this comment.
Suggested change
| // Ask the model to translate from English to French thanks to a system instruction. | |
| // Ask the model to translate from English to French with a system instruction. |
Sita04
approved these changes
May 13, 2024
…ctable output, removing an assert)
glaforge
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
minherz
approved these changes
May 15, 2024
Comment on lines
+28
to
+36
| public static void main(String[] args) throws Exception { | ||
| // TODO(developer): Replace these variables before running the sample. | ||
| String projectId = "your-google-cloud-project-id"; | ||
| String location = "us-central1"; | ||
| String modelName = "gemini-1.5-pro-preview-0409"; | ||
|
|
||
| String output = translateToFrench(projectId, location, modelName); | ||
| System.out.println(output); | ||
| } |
There was a problem hiding this comment.
nit: It is a good practice to exclude the code of main() from the code snippet. To do this you need to place TWO region tag START/END comments around necessary imports and around the code sample method.
Comment on lines
+52
to
+53
| output = ResponseHandler.getText(response); | ||
| return output; |
There was a problem hiding this comment.
nit: I think it can be a direct return.
rafaelMurata
pushed a commit
to rafaelMurata/java-docs-samples
that referenced
this pull request
May 27, 2024
* Remove the preview package Add a function calling example * Missing license header * chore(Checkstyle tweak) * Add missing region tag Fix typo in project ID string * Use the latest libraries-bom that references the 0.4.0 version of the google-cloud-vertexai SDK Use the same example for the token count as in Python and Golang * feat(vertexai): Multimodal snippets using Gemini 1.5 * feat(vertexai): Multimodal snippets using Gemini 1.5 (checkstyle and header tweaks) * feat(vertexai): Multimodal snippets using Gemini 1.5 (incorporating feedback, fixing region tags, and clarifying comments) * chore(vertexai): Update to the latest version of the libraries-bom * chore(vertexai): tweak tests * feat(vertexai): System instruction example * feat(vertexai): Add region tag for system instruction test * feat(vertexai): Add region tag for system instruction test (comment nit) * feat(vertexai): Add region tag for system instruction test (non-predictable output, removing an assert)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes b/338204721
(internal bug reference)
Add support for system instruction.