chore: comment about how to instantiate logger variable in Cloud Run #9340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This App.java is referenced in https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java. But the document does not explain how to instantiate and configure the logger variable. https://cloud.google.com/run/docs/logging#run_manual_logging-java has the answer. So let's add the explanation in the source code comment.
product-auto-label
bot
added
samples
iennae
approved these changes
May 22, 2024
|
@iennae Thank you for quick response. Now I see https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java has been updated. Good. |
rafaelMurata
pushed a commit
to rafaelMurata/java-docs-samples
that referenced
this pull request
May 27, 2024
…oogleCloudPlatform#9340) This App.java is referenced in https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java. But the document does not explain how to instantiate and configure the logger variable. https://cloud.google.com/run/docs/logging#run_manual_logging-java has the answer. So let's add the explanation in the source code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This App.java is referenced in https://cloud.google.com/run/docs/samples/cloudrun-manual-logging#cloudrun_manual_logging-java. But the document does not explain how to instantiate and configure the logger variable.
https://cloud.google.com/run/docs/logging#run_manual_logging-java has the answer. So let's add the explanation in the source code comment.
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only