Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add webhook v1beta1 to default patcher #303

Merged
merged 1 commit into from Aug 4, 2020
Merged

Add webhook v1beta1 to default patcher #303

merged 1 commit into from Aug 4, 2020

Conversation

wangzhen127
Copy link
Contributor

@wangzhen127 wangzhen127 commented Aug 4, 2020 •
edited

This change allows clients to patch webhook objects in cluster bundles. admissionregistration.k8s.io/v1beta1 is available since kubernetes 1.9

@k8s-ci-robot
Copy link
Collaborator

Welcome @wangzhen127! It looks like this is your first PR to GoogleCloudPlatform/k8s-cluster-bundle 🎉

@k8s-ci-robot
Copy link
Collaborator

Hi @wangzhen127. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wangzhen127 wangzhen127 changed the title Add webhook v1,v1beta1 and crd v1 to default patcher Add webhook v1beta1 to default patcher Aug 4, 2020
@wangzhen127
Copy link
Contributor Author

@Kashomon @avrittrohwer You seem like the right people to review this.

@avrittrohwer
Copy link
Collaborator

/ok-to-test

@artasparks artasparks self-requested a review August 4, 2020 17:05
@artasparks
Copy link
Contributor

/lgtm

@artasparks artasparks merged commit 413f809 into GoogleCloudPlatform:master Aug 4, 2020
@wangzhen127 wangzhen127 deleted the scheme branch August 4, 2020 17:44
artasparks pushed a commit to artasparks/k8s-cluster-bundle that referenced this pull request Aug 4, 2020
@wangzhen127 @artasparks
Add webhook v1beta1 to default patcher (GoogleCloudPlatform#303)
49b9195
artasparks pushed a commit to artasparks/k8s-cluster-bundle that referenced this pull request Aug 4, 2020
@wangzhen127 @artasparks
Add webhook v1beta1 to default patcher (GoogleCloudPlatform#303)
134e8c0
artasparks added a commit that referenced this pull request Aug 4, 2020
@artasparks @wangzhen127
Update Release 0.12 (#304)
1dd13df 
* Add webhook v1beta1 to default patcher (#303)

* Update version to 0.12.5

Co-authored-by: Zhen Wang <wangzhen127@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artasparks artasparks artasparks approved these changes

Assignees

@artasparks artasparks

Labels
lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wangzhen127 @k8s-ci-robot @avrittrohwer @artasparks