tests: simplify monitoringdashboard test case, add to tests-e2e-direct

Changing to a random display name is not very intuitive (and doesn't get us much). Also add this to tests-e2e-direct, so we verify the golden output.
GoogleCloudPlatform · May 31, 2024 · 204ca9c · 204ca9c
1 parent aaa5bbd
commit 204ca9c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/...ngdashboard/monitoringdashboardrefs/_generated_object_monitoringdashboardrefs.golden.yaml b/...ngdashboard/monitoringdashboardrefs/_generated_object_monitoringdashboardrefs.golden.yaml
@@ -52,7 +52,7 @@ spec:
           filter: metric.type="agent.googleapis.com/nginx/connections/accepted_count"
           resourceNames: []
         title: Widget 4
-  displayName: monitoringdashboard-${uniqueId}
+  displayName: monitoringdashboard updated
   projectRef:
     external: ${projectId}
   resourceID: monitoringdashboard-${uniqueId}

diff --git a/...testdata/basic/monitoring/v1beta1/monitoringdashboard/monitoringdashboardrefs/update.yaml b/...testdata/basic/monitoring/v1beta1/monitoringdashboard/monitoringdashboardrefs/update.yaml
@@ -17,7 +17,7 @@ kind: MonitoringDashboard
 metadata:
   name: monitoringdashboard-${uniqueId}
 spec:
-  displayName: "monitoringdashboard-${uniqueId}"
+  displayName: "monitoringdashboard updated"
   columnLayout:
     columns:
     - weight: 2

diff --git a/scripts/github-actions/tests-e2e-direct.sh b/scripts/github-actions/tests-e2e-direct.sh
@@ -38,7 +38,7 @@ KCC_USE_DIRECT_RECONCILERS=LoggingLogMetric \
 GOLDEN_OBJECT_CHECKS=1 \
 GOLDEN_REQUEST_CHECKS=1 \
 E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock \
-  go test -test.count=1 -timeout 600s -v ./tests/e2e -run 'TestAllInSeries/fixtures/explicitlogmetric|TestAllInSeries/fixtures/exponentiallogmetric|TestAllInSeries/fixtures/linearlogmetric|TestAllInSeries/fixtures/logbucketmetric'
+  go test -test.count=1 -timeout 600s -v ./tests/e2e -run 'TestAllInSeries/fixtures/explicitlogmetric|TestAllInSeries/fixtures/exponentiallogmetric|TestAllInSeries/fixtures/linearlogmetric|TestAllInSeries/fixtures/logbucketmetric|TestAllInSeries/fixtures/monitoringdashboard'
 
 echo "Running scenarios tests for LoggingLogMetric direct reconciliation..."