Add GKE cgroupMode Support #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erated files * Resource ContainerCluster(v1beta1): * Added `spec.nodeConfig.linuxNodeConfig.cgroupMode` field. * Removed `spec.nodeConfig.linuxNodeConfig.required` field. * Resource ContainerNodePool(v1beta1): * Added `spec.nodeConfig.linuxNodeConfig.cgroupMode` field. * Removed `spec.nodeConfig.linuxNodeConfig.required` field.
|
/lgtm @gbrayut thank you for supporting the new fields with thorough testing and description! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maqiuyujoyce The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 422cb56
into
GoogleCloudPlatform:master
8 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add GKE cgroupMode Support
GKE 1.26 and later use cgroupv2 by default but has options for specifying CGROUP_MODE_V1, CGROUP_MODE_V2, or CGROUP_MODE_UNSPECIFIED via linux Config section. KCC currently supports sysctls settings in linuxNodeConfig, but not cgroupMode.
This PR backports the terraform provider implementation of cgroupMode from hashicorp/terraform-provider-google-beta#6435
Internal ticket: b/328125862
Tests Completed
make ready-prto ensure this PR is ready for review.go test -v -tags=integration ./pkg/controller/dynamic/ -test.run TestCreateNoChangeUpdateDelete -run-tests basic-containercluster -timeout 1800s | tee /tmp/outpython3 scripts/generate-field-diffs-tf-upgrade/generate_field_changes.pyresults: