-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Introduce internal annotation to force reconciliation #1800
tests: Introduce internal annotation to force reconciliation #1800
Conversation
8e6fc44
to
6708226
Compare
/hold CI needs #1799 to run or an early sha as base ref. Feel free to cancel as needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked at the last commit and I like it! 💯
Would you want to rebase/ discard the commits that have already been merged into main?
pkg/k8s/constants.go
Outdated
@@ -113,6 +114,9 @@ var ( | |||
OrgIDAnnotation, | |||
} | |||
|
|||
// Internal Annotation to force reconciliation | |||
InternalForceReconcileAnnotation = CNRMInternalGroup + "/reconcile-cookie" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may be overkill but do we want to prevent modifying this anon for non test usage?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your change to make it test
, it clearly signals that this should not be relied on in prod. If we discover that people are (ab)using it, that's interesting info and we should probably implement a similar production-suitable feature (which might not actually look very different, but .... shrug)
b55c68b
to
3d5786f
Compare
The test.cnrm.cloud.google.com/reconcile-cookie annotation can be changed without affecting the "true" desired state, but we special case the annotation in our filtering, so that it still triggers the reconciler. Co-authored-by: alex <8968914+acpana@users.noreply.github.com>
3d5786f
to
6f3b93f
Compare
/lgtm Thank you for the quick fix! (I hit the LLM lazy reconcile flakiness as well). And it is really good to learn the predicate usage with such an example 🌞 |
/hold cancel #1799 has been merged. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
040a9a2
into
GoogleCloudPlatform:master
The test.cnrm.cloud.google.com/reconcile-cookie annotation can be
changed without affecting the "true" desired state, but we special-case the annotation in our filtering, so that it still triggers the
reconciler.