mockGCP: mock containeranalysisnote #1844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
4 times, most recently
from
8344460
to
1d4da87
Compare
justinsb
reviewed
May 21, 2024
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
2 times, most recently
from
d00f08d
to
007a0ce
Compare
gemmahou
changed the title
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
4 times, most recently
from
fe56bbc
to
470407d
Compare
justinsb
reviewed
May 22, 2024
...xture/testdata/basic/containeranalysis/v1beta1/containeranalysisnote/_vcr_cassettes/dcl.yaml
Outdated
Show resolved
Hide resolved
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
2 times, most recently
from
a8ee24f
to
fc8d6bf
Compare
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
from
fc8d6bf
to
1e19291
Compare
yuwenma
reviewed
May 31, 2024
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
4 times, most recently
from
09a7c8b
to
338be2e
Compare
yuwenma
reviewed
Jun 10, 2024
mockgcp/bigquery-v2.json
Outdated
There was a problem hiding this comment.
Can we group these json file and put them under mockgcp/mockcontaineranalysis?
yuwenma
reviewed
Jun 10, 2024
...est/resourcefixture/testdata/basic/containeranalysis/v1beta1/containeranalysisnote/_http.log
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
nit: Shall we put these under third_party/googlepais/mockcontaineranalysisnote/ ? What I"m thinking is for future maintenance, under mockgrafeas could make it harder to discover and reuse. But this is just a nit
|
/lgtm |
|
/hold for addressing comments |
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
from
338be2e
to
ba56aab
Compare
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
from
ba56aab
to
7257514
Compare
gemmahou
force-pushed
the
mock-containeranalysisnote
branch
from
7257514
to
5ad80ee
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 0f65a10
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
Add mockGCP for ContainerAnalysisNote
Tests you have done
make ready-prto ensure this PR is ready for review.