chore: normalize status.observedState.etag in golden tests #2064
Conversation
Also simplify etag computation, as we don't rely on the value itself any more.
|
/assign @yuwenma |
|
(I did this because it blocked #2052 ) |
| return "W/" + strong | ||
| } | ||
|
|
||
| func ComputeEtagBytes(obj proto.Message) []byte { |
There was a problem hiding this comment.
I checked the current in-use ComputeEtag. Some expects a []byte form and some needs a pointer. So I'm trying to make this a generic lib for other contributors to use out of the box, so they don't need to handle the dereference pointer badly (like what I did previously).
|
/lgtm
Ah! Fair |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit e0f4d1b
into
GoogleCloudPlatform:master
Also simplify etag computation, as we don't rely on the value itself
any more.