Make context optional for evaluation #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barney-s
force-pushed
the
context-optional
branch
from
1a685b5
to
79c472d
Compare
|
Looks good, does this mean that not all composition uses context? (since so far my understanding is that all compositions use context and will generate a plan) |
justinsb
reviewed
Jun 20, 2024
experiments/compositions/composition/internal/controller/expander_reconciler.go
Show resolved
Hide resolved
barney-s
force-pushed
the
context-optional
branch
from
79c472d
to
2d0c37a
Compare
…itions and especially compositions that are not cloud examples
barney-s
force-pushed
the
context-optional
branch
from
2d0c37a
to
64ab9c4
Compare
Yes for non-cloud resources, |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaoweim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit aa89ccf
into
GoogleCloudPlatform:master
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
This is to allow simpler compositions and especially compositions that don't use any cloud resources.