Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acquire test for gkehubfeaturemembership #2103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ziyue-101
Copy link
Collaborator

@ziyue-101 ziyue-101 commented Jun 22, 2024

Change description

Add acquire test and the PR should also test for the abandon-on-delete

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

@ziyue-101 ziyue-101 requested a review from justinsb June 22, 2024 01:10
@ziyue-101
Copy link
Collaborator Author

ziyue-101 commented Jun 22, 2024

/assign @justinsb
/assign @yuwenma
/cc @haiyanmeng

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ziyue-101 ziyue-101 force-pushed the hub_scenario_acquire branch 3 times, most recently from b57f46b to d97706a Compare June 26, 2024 18:22
tests/e2e/normalize.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants