fix: replace targetId with id marker #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinsb
reviewed
Jun 22, 2024
| @@ -127,7 +127,7 @@ X-Xss-Protection: 0 | |||
| "selfLink": "https://www.googleapis.com/compute/beta/projects/${projectId}/global/operations/${operationID}", | |||
| "startTime": "2024-04-01T12:34:56.123456Z", | |||
| "status": "RUNNING", | |||
| "targetId": "7780111738275460050", | |||
| "targetId": "1719033726205916358", | |||
There was a problem hiding this comment.
I don't get why this one wasn't replaced. Looking at the code it should have been, I think. Maybe/hopefully you just need to recapture the golden output here?
There was a problem hiding this comment.
😆 ah, yes. I reminded myself to recapture the golden log while waiting for another full fixtures run. It took too long and I totally forgot this.
yuwenma
force-pushed
the
stricter-test-targetid
branch
from
c195bd5
to
f35056c
Compare
justinsb
approved these changes
Jun 22, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit 405467f
into
GoogleCloudPlatform:master
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to #1934 and blocks #2061
We need to fix the existing golden log to turn on the stricter PRESUBMIT check.
More context: many golden http log uses targetId (see https://github.com/GoogleCloudPlatform/k8s-config-connector/pull/2061/files#diff-45e74dc3e22d6fbc3f979edfe4959d40c702bf51bea40854de4e4ab393bb5330). Override the targetId may be a little bit too aggressive.
cc @acpana