Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support observed state validation via GitHub action #2128

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maqiuyujoyce
Copy link
Collaborator

@maqiuyujoyce maqiuyujoyce commented Jun 25, 2024

Change description

Leveraged the VCR testing and the golden object comparison to verify that observed state fields are populated properly after a successful reconciliation.

Added the observed state test into the presubmit test.

Added instructions about how to generate observed state test data.

Tests you have done

  • [N/A] Run make ready-pr to ensure this PR is ready for review.
  • [N/A] Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from maqiuyujoyce. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@maqiuyujoyce maqiuyujoyce force-pushed the 202406-2051-add-presubmit-test branch from fb51014 to cadbc69 Compare June 27, 2024 00:31
echo "Running e2e fixtures test with vcr replay mode..."

E2E_KUBE_TARGET=envtest RUN_E2E=1 \
E2E_GCP_TARGET=vcr VCR_MODE=replay GOLDEN_OBJECT_CHECKS=1 \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be missing some more context here but why can't we rely on the existing golden objects exports GOLDEN_OBJECT_CHECKS=1 in our fixtures and samples ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I used VCR originally because there was no mock for the specific resources at the time when I started working on it or the mock doesn't populate all the fields I want. Will take a look at the mock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants