This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Rebase k8s images to distroless. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of the effort described in KEP kubernetes/enhancements#900
|
/assign @ihmccreery |
|
Will |
|
It will and it does have stable tags. We previously have a discussion about using "latest" or a specific tag. I think the conclusion is that as a tradeoff between extra manual effort on updating the tags periodically vs. ignoring the base image version reason on triaging a problem, we prefer the latter. Is it reasonable on your side? |
|
Normally I'd say that it's always correct to pin the base image to a stable tag (or, better yet, a digest). Given that the spirit of this image is to be usefully minimal, and that the distroless repo itself seems to recommend |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the effort described in KEP kubernetes/enhancements#900