Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCB config for fluentd-gcp build #107

Conversation

rvkubiak
Copy link

Adds a Google Container Builder config to build the fluentd-gcp image.
This will be used for build automation of Kubernetes addon images.

Adds a Google Container Builder config to build the fluentd-gcp image.
This will be used for build automation of Kubernetes addon images.
@x13n
Copy link
Contributor

x13n commented Feb 22, 2018

I think fluentd-gcp-image going away in favor of stackdriver-logging-agent. cc @crassirostris @bmoyles0117

@rvkubiak
Copy link
Author

@tallclair Tim, do we want to remove fluentd-gcp-image from the list of core addons?

@rvkubiak
Copy link
Author

As long as the images are in the addons directory included in the Kubernetes release, on any supported release branch (1.7, 1.8, 1.9), then we need to support them (and fix vulnerabilities). There might be a transition period where it's not worth the effort to automate some images that are going away.

Even if this image is being replaced in the future, we still want to automate the builds for current and previously supported releases.

@x13n
Copy link
Contributor

x13n commented Feb 23, 2018

Ack, makes sense. Can you also add some doc/information on how this config will be used?

FWIW, the PR to replace this image is already in flight: kubernetes/kubernetes#59128

There are other addons in this repository, are you going to add GCB configs for them as well?

@rvkubiak
Copy link
Author

Sure, I can add some comments in the config. We identified 30 "core" addons (included in the Kubernetes manifest) to start working with an attempt at build automation. The primary goals of this are to decrease the number of humans with push access to k8s.gcr.io and to establish build provenance for these core addons.

The first set of 30 are more or less a proof of concept. The final plan for how these will be implemented isn't complete yet. Today these images are not regularly rebuilt, and we're aiming to use these configs to drive automated rebuilds based on criteria that aren't yet defined. One idea is to automatically rebuild and deploy when tags are pushed, but we need to get the community (specifically add-on owners) on board with a process.

We're using the first 30 as a proof of concept, and we're going to be seeking involvement from the community to determine what the final implementation will look like and help create the rest of the configs.

Other images from GoogleCloudPlatform that were identified as part of these 30 are event-exporter, kubelet-to-gcm, and prometheus-to-sd.

@rvkubiak
Copy link
Author

Moving these configs to their own repo.

@rvkubiak rvkubiak closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants