New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumped fluentd from 0.12.32 to 1.2.5 #148
base: master
Are you sure you want to change the base?
Conversation
fluentd-gcp-image/Gemfile
Outdated
@@ -1,6 +1,6 @@ | |||
source 'https://rubygems.org' | |||
|
|||
gem 'fluentd', '~>0.12.32' | |||
gem 'fluentd', '~>0.14.25' | |||
gem 'fluent-plugin-record-reformer', '~>0.8.3' | |||
gem 'fluent-plugin-systemd', '~>0.0.8' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't fluent-plugin-systemd > 0.1.0
required for fluentd >= 0.14.11 as per https://github.com/reevoo/fluent-plugin-systemd#requirements ?
Yes, Bumped fluent-plugin-systemd to 0.3.1 to be compatible with fluentd 0.14.x. Please take another look. |
/retest |
@deejay1 please take another look |
Hi Yu, Thanks |
The big issue that I think this will fix is the fact that Google Kubernetes Engine truncates logs to second resolution. I think the underlying cause is this fluent-plugin-google-cloud bug, which was fixed in v0.6.9 (already included in this image I think): GoogleCloudPlatform/fluent-plugin-google-cloud#131 However, that will only work with fluentd >= 0.14 since before that it represents time as seconds: https://www.fluentd.org/blog/fluentd-v0.14.0-has-been-released |
See the GKE issue for this also: https://issuetracker.google.com/issues/35903605 |
Bumped fluent-plugin-systemd to 0.3.1 to be compatible with fluentd 1.2.5.
@loburm it seems that fluentd 1.2.5 is stable, and qualified, updated this PR to upgrade to v1.2.5. PTAL |
@@ -1,8 +1,8 @@ | |||
source 'https://rubygems.org' | |||
|
|||
gem 'fluentd', '~>0.12.32' | |||
gem 'fluentd', '~>1.2.5' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we have only qualified this version of fluentd as it pertains to the Docker image we distribute (i.e., the one built from https://github.com/GoogleCloudPlatform/google-fluentd/blob/master/docker/Dockerfile). There is no evidence that it will work properly for this Docker image. Should this not be obsoleted now that we are providing one?
@qingling128 @bmoyles0117 FYI.
1.2.5 is stable, tested, and has the feature to support nanosecond timestamp.