add http4k #113
Merged
add http4k #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
bshaffer
reviewed
Jan 22, 2021
There was a problem hiding this comment.
@jamesward for starters can we add this to the github actions tests.yaml file?
|
Done. |
bshaffer
reviewed
Jan 22, 2021
| with: | ||
| arguments: test --console=plain --info | ||
| build-root-directory: run/grpc-hello-world-bidi-streaming | ||
| wrapper-directory: run/grpc-hello-world-bidi-streaming |
There was a problem hiding this comment.
🥂 I was hoping you'd add this one!!
| 1. Build the container image on Cloud Build using Buildpacks (currently an alpha feature), storing the image on Google Container Registry: | ||
| ``` | ||
| export PROJECT_ID=YOUR_GCP_PROJECT | ||
| gcloud alpha builds submit --pack=image=gcr.io/$PROJECT_ID/http4k-hello-world |
There was a problem hiding this comment.
is alpha intentional here?
There was a problem hiding this comment.
Just a copy & paste thing. Will resolve with #117
bshaffer
approved these changes
Jan 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.