Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor readability issues #113

Merged
merged 1 commit into from Feb 21, 2020
Merged

Conversation

rakyll
Copy link
Contributor

@rakyll rakyll commented Feb 13, 2020

  • Avoid the intermediate variable names where possible.
  • Don't name a ServeMux as a server.
  • Move the PORT below where it contextually is more relevant.
  • Keep hello-aoo and quickstart consistent.

- Avoid the intermediate variable names where possible.
- Don't name a ServeMux as a server.
- Move the PORT below where it contextually is more relevant.
- Keep hello-aoo and quickstart consistent.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2020
@rakyll rakyll requested a review from bshaffer February 13, 2020 19:09
@bshaffer bshaffer merged commit 3fcb2fe into GoogleCloudPlatform:master Feb 21, 2020
@rakyll rakyll deleted the helloapp branch February 21, 2020 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants