add gke-whereami to samples #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
askmeegs
requested changes
Jul 29, 2020
There was a problem hiding this comment.
Hi Alex, looks great, a few comments - mostly formatting.
I tested by:
- Building my own container image using your Dockerfile
- Creating a new GKE cluster (spec-ed to your README)
- Deployed my whereami image to my cluster, with
kustomize build, thenkubectl apply -k - Verified that all JSON output fields on
curlwere populated, and correct, for a single cluster use case. - Verified that the ENABLE_BACKEND configmap option works with the same deploy instructions (see notes about cluster resourcing)
mark-church
reviewed
Jul 30, 2020
mark-church
reviewed
Jul 30, 2020
theemadnes
commented
Aug 1, 2020
askmeegs
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per internal discussion, adding
gke-whereamito GKE samples to enable public-facing multicluster demos