Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README and file structure updates for whereami app #133

Merged
merged 3 commits into from
Aug 4, 2020
Merged

README and file structure updates for whereami app #133

merged 3 commits into from
Aug 4, 2020

Conversation

mark-church
Copy link
Contributor

  • Updated README
    • Separated into 3 sections - simple deployment, full deployment, and backend service call
    • Added descriptions to YAML examples to highlight areas of the config
  • Moved the entire folder from gke-whereami to whereami. Reason for this is that the app is not actually GKE specific so I wanted to give it a little bit more of a generic name.
  • Created a k8s-frontend-overlay-example folder so we could keep the "full deployment" config a little cleaner and completely separate their configs

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 3, 2020
@mark-church mark-church changed the title README and file structure updates README and file structure updates for whereami app Aug 3, 2020
askmeegs
askmeegs approved these changes Aug 3, 2020
View reviewed changes
Copy link
Contributor

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment @mark-church otherwise LGTM!

@mark-church
Copy link
Contributor Author

@theemadnes let me know if you are okay with these changes and I will submit

@mark-church
Copy link
Contributor Author

@askmeegs btw I don't have write access to the repo so I can't merge myself

@askmeegs askmeegs merged commit d9fa6f8 into GoogleCloudPlatform:master Aug 4, 2020
@mark-church mark-church mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mark-church @askmeegs @googlebot