Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC support for whereami #150

Merged
merged 21 commits into from
Nov 2, 2020
Merged

gRPC support for whereami #150

merged 21 commits into from
Nov 2, 2020

Conversation

theemadnes
Copy link
Member

updated whereami to include a whereami-grpc option where the service(s) listen on port 9090 and support the gRPC protocol. Includes proto definitions and supports the gRPC health check.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@theemadnes theemadnes mentioned this pull request Oct 22, 2020
@theemadnes theemadnes changed the title gRPC support gRPC support for whereami Oct 22, 2020
Copy link
Contributor

@askmeegs askmeegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few readme comments, and having issues with the build, but otherwise your implementation looks good! Thanks for adding this!

whereami/README.md Outdated Show resolved Hide resolved
whereami/README.md Show resolved Hide resolved
whereami/README.md Show resolved Hide resolved
whereami/README.md Show resolved Hide resolved
@askmeegs
Copy link
Contributor

askmeegs commented Nov 2, 2020

  • Verified that docker build runs successfully.
  • Verified v1.1.0 against the gRPC readme instructions.
  • Verified v1.1.0 against the HTTP readme instructions

@askmeegs askmeegs merged commit f0f63c7 into GoogleCloudPlatform:master Nov 2, 2020
@theemadnes theemadnes deleted the grpc_support branch November 2, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants