Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service port validation #974

Closed
bgrant0607 opened this issue Aug 20, 2014 · 6 comments
Closed

Service port validation #974

bgrant0607 opened this issue Aug 20, 2014 · 6 comments
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@bgrant0607
Copy link
Member

AFAICT, ValidateService doesn't check that a port is specified. What happens when no port is specified?

I also can't find anywhere where we check that 2 services don't ask for the same port.

Additionally, host ports may conflict with service ports. It would be useful to report such conflicts and to prevent the creation of services that conflict with host ports and vice versa.

@bgrant0607 bgrant0607 added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 8, 2014
@brendandburns brendandburns added this to the v0.5 milestone Sep 9, 2014
@brendandburns brendandburns self-assigned this Sep 10, 2014
@brendandburns brendandburns reopened this Sep 24, 2014
@brendandburns
Copy link
Contributor

oops...

@brendandburns
Copy link
Contributor

This issue is largely deprecated. Will close with IP per service lands.

@thockin
Copy link
Member

thockin commented Sep 30, 2014

IP-per-service does not eliminate this.

Even after ip-per-service, some Services will have to use HostPorts (for External Load Balancer, for now). Much reduced, but that just makes a conflict even less common and harder to debug.

It boils down to: both Pods and Services can use HostPorts. We currently check Pods against other Pods for host-port conflicts, but we do not check Pods against Services, nor vice-versa, nor Services against Services.

We need some common way for both resource classes to check for conflicts and reserve HostPorts atomically.

@brendandburns
Copy link
Contributor

Closing this as it is now obsolete with service v2.

@craigmcl
Copy link

This is to be addressed in v0.5.

@bgrant0607 bgrant0607 reopened this Oct 29, 2014
@brendandburns
Copy link
Contributor

Closing this, as it is no longer possible for services and pods to have port conflicts, unless a user does something manual (like specify a host IP for the "PublicIP" for a service)

vishh pushed a commit to vishh/kubernetes that referenced this issue Apr 6, 2016
josefkarasek pushed a commit to josefkarasek/kubernetes that referenced this issue Oct 27, 2021
…rry-pick-959-to-release-4.9

Bug 2006717: etcd-client starts retrying transient errors from the etcd cluster
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

4 participants