Make validation check for legal service port numbers. #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -260,6 +260,10 @@ func ValidateService(service *Service) errs.ErrorList { | |||
| } else if !util.IsDNS952Label(service.ID) { | |||
| allErrs = append(allErrs, errs.NewInvalid("Service.ID", service.ID)) | |||
| } | |||
| // Make sure the service port number is valid. | |||
There was a problem hiding this comment.
This comment seems unnecessary.
There was a problem hiding this comment.
Personally, I think the comment is helpful, but I am removing it as per your suggestion.
|
A couple nits, otherwise LGTM |
|
LGTM (assuming fixes to @lavalamp's comments) |
|
OK: I'm done with my changes in response to (most) of the comments above. If there is a strong desire to change this to a table driven test then I can do that. Thank you. |
|
Thanks fort the change! |
lavalamp
added a commit
that referenced
this pull request
Aug 25, 2014
Make validation check for legal service port numbers.
vishh
pushed a commit
to vishh/kubernetes
that referenced
this pull request
Apr 6, 2016
Fix goroutine leak in docker fs handler logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought I would have a crack at the bug "Service port validation #974".
This request only deals with checking valid port numbers in the Port field of Service but does not deal with port number clashes between multiple services.